This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] new memory-changed MI notification.


On 09/28/2012 03:36 PM, Eli Zaretskii wrote:
If @var{type} can only be "code", then I suggest to say

...[,type=code]

explicitly.


@var{type} can only "code" nowadays, but I am wondering we may have other types, such as "data", in the future. I don't want to give the consumer of this notification an impression that "type=code" is hard-coded into notification. If we don't have to worry about it at all, "[,type=code]" is fine to me.


Btw, why "code"?  If this is the name of the section, it should be
".text", not code.

From the consumer of this notification's point of view, 'type' is more useful than 'name', because the consumer may don't know what ".text" section is, or on some ports, text section is not named as ".text", such as section ".text_vle" for VLE.


--
Yao


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]