This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] Add missing gdb_bfd.h includes
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 26 Sep 2012 23:30:43 +0200
- Subject: RE: [RFA] Add missing gdb_bfd.h includes
- References: <18620.4427075156$1348564388@news.gmane.org> <87a9wcy2no.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: mercredi 26 septembre 2012 22:01
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] Add missing gdb_bfd.h includes
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
>
> Pierre> Is this OK?
>
> Yes, thank you.
OK, patch committed in
http://sourceware.org/ml/gdb-cvs/2012-09/msg00156.html
> Pierre> As usual,
> Pierre> 1) I am not sure about correct wording for ChangeLog
>
> What you wrote is fine.
>
> Pierre> 2) I never really understood the ordering logic (or to
> Pierre> be more precise, if there is an ordering logic) of C headers
> Pierre> in C source files, thus I inserted them more or less randomly...
>
> There should not be many strong ordering dependencies in gdb, aside from
> the rule that defs.h has to come first. I wouldn't worry about it in
> general.
Thanks for the clarification,
Pierre