This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Failure to stop at duplicate breakpoints


On 26/09/2012 4:06 PM, Pedro Alves wrote:
> On 09/25/2012 10:48 PM, Andrew Burgess wrote:
>> Pedro,
>>
>> Thanks for taking the time to review my patch.  I've addressed the issues you raised, and 
> 
> Great, thanks.  Just one little more I missed before:
> 
>> +standard_testfile
>> +
>> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
>> +    return -1
>> +}
>> +
>> +# Setup for the test, create COUNT breakpoints at the function BREAKPT.
>> +proc test_setup { count } {
>> +    global srcfile
> 
>     global binfile
> 
> and
> 
>> +    clean_restart duplicate-bp
> 
> instead:
> 
>     clean_restart $binfile
> 
> Okay with that change.  Thanks again.

Have committed with that small fix.

Thanks for your review.
Andrew





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]