This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Fix wrong length computed in mi_cmd_data_write_memory_bytes.


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> I happen to see that MI command '-data-write-memory-bytes' doesn't write
Yao> contents correctly to memory, for example,
Yao>   -data-write-memory-bytes &x "1"

I think that this is invalid input.

The argument to -data-write-memory-bytes is encoded as hex.
So, it has to be a multiple of 2 characters.

I guess we could still go with this patch, but I think it would require
a discussion about why it is preferable to do this as opposed to simply
giving an error.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]