This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)
- From: KARTHIKVENKATESH BHAT <kv dot bhat at samsung dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 26 Sep 2012 14:19:04 +0000 (GMT)
- Subject: Re: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)
- Dlp-filter: Pass
- Msgkey: 20120926141633640@kv.bhat
- Reply-to: kv dot bhat at samsung dot com
Thanks. I have added PR number to Changelog as mentioned.
------- Original Message -------
Sender : Yao Qi<yao@codesourcery.com>
Date : Sep 26, 2012 22:45 (GMT+09:00)
Title : Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)
On 09/26/2012 08:23 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks for the review. Committed after formatting.
The changelog entry is too long, usually it should not exceed 70
characters, and there is a trailing space. I fixed it in the
patch below.
Your patch fixes a PR, so you should add the PR number into your
changelog entry, so that bugzilla can link this commit to the PR, like
this,
2012-09-26 Karthik Bhat
PR breakpoints/14419
* arm-tdep.c (arm_skip_prologue): XXXX
--
Yao
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14700
diff -u -r1.14700 ChangeLog
--- ChangeLog 26 Sep 2012 12:14:30 -0000 1.14700
+++ ChangeLog 26 Sep 2012 13:36:17 -0000
@@ -1,6 +1,7 @@
2012-09-26 Karthik Bhat
- * arm-tdep.c (arm_skip_prologue): Extending producer check to support LLVM compiler.
+ * arm-tdep.c (arm_skip_prologue): Extending producer check to
+ support LLVM compiler.
2012-09-26 Siddhesh Poyarekar