This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Add a test case for the jit-reader interface.

From: Tom Tromey <tromey at redhat dot com>
To: Sanjoy Das <sanjoy at playingwithpointers dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 18 Sep 2012 13:36:16 -0600
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com> <1347942847-31510-4-git-send-email-sanjoy@playingwithpointers.com>

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +2012-09-18  Sanjoy Das <sanjoy@playingwithpointers.com>

Thanks.  This is very nice.

Sanjoy> +	* gdb.base/jit-reader.exp (new): Test case for the jit-reader
Sanjoy> +	interface.
Sanjoy> +	* gdb.base/jithost.c (new): Do.
Sanjoy> +	* gdb.base/jithost.h (new): Do.
Sanjoy> +	* gdb.base/jitreader.c (new) : Do.

Those should be like:

	* gdb.base/jithost.c: New file.

Sanjoy> +# Note: compiling without debug info: the library goes through symbol
Sanjoy> +# renaming by munging on its symbol table, and that wouldn't work for .debug
Sanjoy> +# sections.  Also, output for "info function" changes when debug info is resent.

Bad copy&paste :)
I think this comment isn't relevant & can be deleted.

Sanjoy> +    gdb_test "run" ".*"

Use gdb_run_cmd instead.

Tom

References:
- [PATCH 0/3] Fix recent breakage in the JIT reader interface
  - From: Sanjoy Das
- [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Sanjoy Das

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]