This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v3 04/16] source, disasm: optionally prefix source lines with filename
- From: Tom Tromey <tromey at redhat dot com>
- To: markus dot t dot metzger at intel dot com
- Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at gmail dot com, jan dot kratochvil at redhat dot com, palves at redhat dot com, kettenis at gnu dot org
- Date: Tue, 11 Sep 2012 14:20:40 -0600
- Subject: Re: [patch v3 04/16] source, disasm: optionally prefix source lines with filename
- References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-5-git-send-email-markus.t.metzger@intel.com>
>>>>> "Markus" == markus t metzger <markus.t.metzger@intel.com> writes:
Markus> * source.c (print_source_lines_base): Prefix source line with filename if
This line looks over-long.
Markus> + print_source_lines (symtab, next_line, mle[i].line + 1, psl_flags);
A few of these lines look too long as well, they should be split.
Otherwise this seems ok.
Tom