This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [RFC] New GDB Port CR16

From: Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Yao Qi <yao at codesourcery dot com>
Date: Thu, 30 Aug 2012 05:23:00 +0000
Subject: RE: [RFC] New GDB Port CR16
References: <C6CA53A2A46BA7469348BDBD663AB65845B27868@KCHJEXMB03.kpit.com> <503B9E59.6050502@codesourcery.com> <C6CA53A2A46BA7469348BDBD663AB65845B28084@KCHJEXMB03.kpit.com> <CAJaTeTrp4cCM6-0WybhzQnH_ZDBoa9xDhnW4+QGtaS7Un3Zv=Q@mail.gmail.com>

Hi Mike,
Thanks for detailed review.

> needs a space there: > +	    switch(a)
> just one space after "case"
> also, the comment should have two spaces before the */:

I have fixed the above three issues in the attached patch.
If everything else looks OK, could you please check these in for me as I
do not have write privileges to the repository?

I will create a separate thread for cr16 gdb related patches.

Best Regards,
Kaushik
KPIT Cummins Infosystems Ltd
www.kpitcummins.com

Attachment: cr16_sim.diff
Description: cr16_sim.diff

Follow-Ups:
- Re: [RFC] New GDB Port CR16
  - From: Mike Frysinger

References:
- [RFC] New GDB Port CR16
  - From: Kaushik Phatak
- Re: [RFC] New GDB Port CR16
  - From: Yao Qi
- RE: [RFC] New GDB Port CR16
  - From: Kaushik Phatak
- Re: [RFC] New GDB Port CR16
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]