This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 2/2] Remove pass in skip_unwinder_tests


Hi,
As we discussed, proc skip_unwinder_tests should not generate any FAIL
or PASS in test summary, so this patch is a follow-up to to remove
'pass', and replace gdb_test_multiple with send_gdb/gdb_expect.  With
this patch applied, these PASS are disappeared in test result.

 -PASS: gdb.cp/nextoverthrow.exp: check for unwinder hook
 -PASS: gdb.cp/nextoverthrow.exp: check for stap probe in unwinder
 -PASS: gdb.java/jnpe.exp: check for unwinder hook
 -PASS: gdb.java/jnpe.exp: check for stap probe in unwinder

gdb/testsuite:

2012-08-23  Yao Qi  <yao@codesourcery.com>

	* lib/gdb.exp (skip_unwinder_tests): Replace 'gdb_test_multiple'
	with 'send_gdb' and 'gdb_expect'.  Remove pass.
---
 gdb/testsuite/lib/gdb.exp |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 0b02f76..99d6591 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2102,25 +2102,22 @@ proc skip_unwinder_tests {} {
     global gdb_prompt
 
     set ok 1
-    gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
+
+    send_gdb "print _Unwind_DebugHook\n"
+    gdb_expect {
 	-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
-	    # Pass the test so we don't get bogus fails in the results.
-	    pass "check for unwinder hook"
 	    set ok 0
 	}
 	-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
-	    pass "check for unwinder hook"
 	}
 	-re "No symbol .* in current context.\r\n$gdb_prompt $" {
-	    # Pass the test so we don't get bogus fails in the results.
-	    pass "check for unwinder hook"
 	    set ok 0
 	}
     }
     if {!$ok} {
-	gdb_test_multiple "info probe" "check for stap probe in unwinder" {
+	send_gdb "info probe\n"
+	gdb_expect {
 	    -re ".*libgcc.*unwind.*\r\n$gdb_prompt $" {
-		pass "check for stap probe in unwinder"
 		set ok 1
 	    }
 	    -re "\r\n$gdb_prompt $" {
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]