This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: printing pointers to global (data) variable on Windows...


> What about defaulting it to zero, applying the appended, and then fixing
> up the fallout?

I thought about that too, and got concerned about missing some places.
However, I very much like one thing about your patch, which is the fact
that it now forces the use of a "setter" to change the value of the
msymbol size, and that answers my main worry. And just because of the
"setter" alone, I'd go with this approach.

We could go with this appraoch independently of the has_size flag first,
and then add the flag. The one tiny concern is for readers that did not
set the size of zero-sized symbols because it knew that the default
was already zero.

> I could do the mechanics of this if you think it is ok; and if you plan
> to go forward with this.

Thanks for the kind offer - I brought this up, I should really be
doing the work...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]