This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] remove TYPE_CODE_BITSTRING
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2012-08-10 Yao Qi <yao@codesourcery.com>
Yao> * gdbtypes.h (enum type_code): Remove TYPE_CODE_BITSTRING.
This one needs a little tweak.
Yao> diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
Yao> index 98030a6..dc7af9f 100644
Yao> --- a/gdb/python/py-type.c
Yao> +++ b/gdb/python/py-type.c
Yao> @@ -98,7 +98,6 @@ static struct pyty_code pyty_codes[] =
Yao> ENTRY (TYPE_CODE_SET),
Yao> ENTRY (TYPE_CODE_RANGE),
Yao> ENTRY (TYPE_CODE_STRING),
Yao> - ENTRY (TYPE_CODE_BITSTRING),
This is actually Python API. Search for TYPE_CODE_BITSTRING in the
manual.
I think it is best to keep the name around, in case anything uses it.
But, we don't have to keep the same value. So I would suggest defining
to be -1 and then updating the manual to note that this code is
deprecated -- or even just undocumenting the constant.
The rest is ok though.
Tom