Re: [PATCH 08/10] microblaze

[Michael Eager <eager at eagerm dot com>]

On 07/31/2012 03:50 AM, Yao Qi wrote:
> gdb:
>
> 2012-07-30  Yao Qi  <yao@codesourcery.com>
>
> 	* microblaze-tdep.c (microblaze_debug_flag): Add 'unsigned'.
> 	(_initialize_microblaze_tdep): Call add_setshow_zuinteger_cmd
> 	intead of add_setshow_zinteger_cmd.
> ---
>   gdb/microblaze-tdep.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c
> index ca59213..9658400 100644
> --- a/gdb/microblaze-tdep.c
> +++ b/gdb/microblaze-tdep.c
> @@ -79,7 +79,7 @@ static const char *microblaze_register_names[] =
>
>   #define MICROBLAZE_NUM_REGS ARRAY_SIZE (microblaze_register_names)
>   
> -static int microblaze_debug_flag = 0;
> +static unsigned int microblaze_debug_flag = 0;
>
>   static void
>   microblaze_debug (const char *fmt, ...)
> @@ -739,13 +739,13 @@ _initialize_microblaze_tdep (void)
>     register_gdbarch_init (bfd_arch_microblaze, microblaze_gdbarch_init);
>
>     /* Debug this files internals.  */
> -  add_setshow_zinteger_cmd ("microblaze", class_maintenance,
> -			    &microblaze_debug_flag, _("\
> +  add_setshow_zuinteger_cmd ("microblaze", class_maintenance,
> +			     &microblaze_debug_flag, _("\
>   Set microblaze debugging."), _("\
>   Show microblaze debugging."), _("\
>   When non-zero, microblaze specific debugging is enabled."),
> -			    NULL,
> -			    NULL,
> -			    &setdebuglist, &showdebuglist);
> +			     NULL,
> +			     NULL,
> +			     &setdebuglist, &showdebuglist);
>
>   }

Why is this needed?

Please remove extraneous whitespace changes at the end of the patch.


--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077