This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] massively speed up "info var foo" on large programs
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: dje at google dot com
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, ratmice at gmail dot com
- Date: Tue, 31 Jul 2012 04:18:45 -0300
- Subject: Re: [RFA] massively speed up "info var foo" on large programs
- References: <20120524175852.D38381E139C@ruffy2.mtv.corp.google.com> <CADPb22T1K5sHhddJtCg0iURbyL7oQngFBVJ23gAsfz58qWQ0Ww@mail.gmail.com> <CADPb22ROtFjAWBrCRVu-8QqHKBjqmR+FSRAonHQMAFPU=m02pA@mail.gmail.com> <4FBF47DD.4030100@redhat.com> <CADPb22Tnz7rK7VpwKW-cwMJm+tMwThoe5h=r=AH_sX=CwQat6g@mail.gmail.com> <4FC91A33.5040900@redhat.com> <CADPb22Tp5auHhj+-=qHW9XDEJfh-N1HjSBGYYYKVXutT-S0Zpw@mail.gmail.com> <4FCCCE27.2060804@redhat.com> <CADPb22Ts13qv-7Y=UckapJmECyheYAoXNTfFes7ZvqsALbcyhw@mail.gmail.com> <m2d33sjein.fsf@igel.home> <20502.50281.392575.922986@ruffy2.mtv.corp.google.com>
On Monday, July 30 2012, dje@google.com wrote:
> I'm not sure how much effort to put into handling all the variations here.
> I'm happy with this, but I'm also happy with anything that fixes your regression.
>
> This is regression tested on amd64-linux.
> Can you try this on m68k-linux? Thanks.
I was seeing the same failures as Andreas on PPC64 and s390x (in fact I
was working on a patch for it now, but you were faster), when I
regtested 7.4 against 7.5 on RHEL 6.3.
I have just tested your patch on ppc64 and it works OK; I don't have a
s390x machine right now but I'll check tomorrow when I wake up.
> 2012-07-30 Doug Evans <dje@google.com>
>
> * gdb.base/info-fun.exp: Fix failures on m68k-linux.
Given that these failures also happen on ppc64 and s390x due to the same
reason, I believe this and the other sentences specifically mentioning
m68k-linux can be more generic.
I also vote for committing this in the 7.5 branch.
Thanks,
--
Sergio