This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/6] attach to command_option-changed observer.

From: Pedro Alves <palves at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 26 Jul 2012 16:31:24 +0100
Subject: Re: [PATCH 3/6] attach to command_option-changed observer.
References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-4-git-send-email-yao@codesourcery.com>

On 07/24/2012 05:10 PM, Yao Qi wrote:
> +  else if (strncmp (parse->command, "gdb-set", sizeof ("gdb-set") - 1 ) == 0)
> +    {
> +      int *p = &mi_suppress_notification[MI_SUPPRESS_COMMAND];

I honestly have trouble mapping "MI_SUPPRESS_COMMAND" to -gdb-set.

This is about =option-changed, so I think MI_SUPPRESS_OPTION_CHANGED would
be clearer.

-- 
Pedro Alves

References:
- [RFC 0/6] MI notification of command option change
  - From: Yao Qi
- [PATCH 3/6] attach to command_option-changed observer.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]