This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/10] change gdb to refcount bfd everywhere

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Mon, 23 Jul 2012 20:53:47 +0200, Tom Tromey wrote:
>> else if (bfd_check_format (abfd, bfd_archive))
>> {
>> -      last = 0;
>> -      /* FIXME??? am I tossing BFDs?  bfd?  */
>> -      while ((last = gdb_bfd_openr_next_archived_file (abfd, last)))
>> +      last = gdb_bfd_openr_next_archived_file (abfd, NULL);
>> +      while (last != NULL)

Jan> So you have resolved this question I see.

Not really to my satisfaction.
I just brought it in line with machoread.c, which is more actively
maintained.

I'll try to dig up a definitive answer.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]