This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/10] change gdb to refcount bfd everywhere
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> I wonder if I should rename it to gdb_bfd_open_maybe_remote, for
Tom> consistency. What do you think? I'm inclined to do it.
Jan> Definitely.
Tom> I'll do this shortly.
Here's that patch.
I'm checking it in.
Tom
2012-07-23 Tom Tromey <tromey@redhat.com>
* symfile.c (separate_debug_file_exists): Update.
(gdb_bfd_open_maybe_remote): Rename from bfd_open_maybe_remote.
(reread_symbols): Update.
* elfread.c (build_id_verify): Update.
* symfile.h (gdb_bfd_open_maybe_remote): Rename from
bfd_open_maybe_remote.
Index: elfread.c
===================================================================
RCS file: /cvs/src/src/gdb/elfread.c,v
retrieving revision 1.136
diff -u -r1.136 elfread.c
--- elfread.c 23 Jul 2012 14:58:44 -0000 1.136
+++ elfread.c 23 Jul 2012 15:03:15 -0000
@@ -1109,7 +1109,7 @@
int retval = 0;
/* We expect to be silent on the non-existing files. */
- abfd = bfd_open_maybe_remote (filename);
+ abfd = gdb_bfd_open_maybe_remote (filename);
if (abfd == NULL)
return 0;
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.341
diff -u -r1.341 symfile.c
--- symfile.c 23 Jul 2012 14:58:44 -0000 1.341
+++ symfile.c 23 Jul 2012 15:03:15 -0000
@@ -1353,7 +1353,7 @@
if (filename_cmp (name, parent_objfile->name) == 0)
return 0;
- abfd = bfd_open_maybe_remote (name);
+ abfd = gdb_bfd_open_maybe_remote (name);
if (!abfd)
return 0;
@@ -1697,7 +1697,7 @@
returns NULL with the BFD error set. */
bfd *
-bfd_open_maybe_remote (const char *name)
+gdb_bfd_open_maybe_remote (const char *name)
{
bfd *result;
@@ -2516,7 +2516,7 @@
obfd_filename = bfd_get_filename (objfile->obfd);
/* Open the new BFD before freeing the old one, so that
the filename remains live. */
- objfile->obfd = bfd_open_maybe_remote (obfd_filename);
+ objfile->obfd = gdb_bfd_open_maybe_remote (obfd_filename);
gdb_bfd_unref (obfd);
}
Index: symfile.h
===================================================================
RCS file: /cvs/src/src/gdb/symfile.h,v
retrieving revision 1.112
diff -u -r1.112 symfile.h
--- symfile.h 20 Jul 2012 17:38:04 -0000 1.112
+++ symfile.h 23 Jul 2012 15:03:15 -0000
@@ -550,7 +550,7 @@
extern bfd *symfile_bfd_open (char *);
-extern bfd *bfd_open_maybe_remote (const char *);
+extern bfd *gdb_bfd_open_maybe_remote (const char *);
extern int get_section_index (struct objfile *, char *);