This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Cleanup: constify struct linespec
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 18 Jul 2012 10:27:04 -0600
- Subject: Re: [RFA] Cleanup: constify struct linespec
- References: <5005A529.5020905@redhat.com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> 2012-07-17 Keith Seitz <keiths@redhat.com>
Keith> * linespec.c (struct linespec): Constify expression,
Keith> source_filename, function_name, and label_name.
Keith> (symbol_not_found_error): Make all parameters const.
Keith> (linespec_parser_delete): No need to check for NULL
Keith> when using xfree. Cast const char * to char * for xfree.
Ok.
FWIW I generally don't like casts like this:
+ xfree ((char *) PARSER_RESULT (parser)->expression);
... but in this case I agree that constifying the struct outweighs this.
Tom