This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: fix output file placement in gdb.reverse


I'm checking this in.

I noticed that tests in gdb.reverse were still putting some output files
into the wrong directory.  This patch fixes the problem.

Tom

2012-07-11  Tom Tromey  <tromey@redhat.com>

	* gdb.reverse/break-precsave.exp: Use standard_output_file.
	* gdb.reverse/consecutive-precsave.exp: Use standard_output_file.
	* gdb.reverse/finish-precsave.exp: Use standard_output_file.
	* gdb.reverse/i386-precsave.exp: Use standard_output_file.
	* gdb.reverse/machinestate-precsave.exp: Use standard_output_file.
	* gdb.reverse/sigall-precsave.exp: Use standard_output_file.
	* gdb.reverse/solib-precsave.exp: Use standard_output_file.
	* gdb.reverse/step-precsave.exp: Use standard_output_file.
	* gdb.reverse/until-precsave.exp: Use standard_output_file.
	* gdb.reverse/watch-precsave.exp: Use standard_output_file.

Index: gdb.reverse/break-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/break-precsave.exp,v
retrieving revision 1.7
diff -u -r1.7 break-precsave.exp
--- gdb.reverse/break-precsave.exp	26 Jun 2012 17:54:59 -0000	1.7
+++ gdb.reverse/break-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -22,6 +22,7 @@
 }
 
 standard_testfile break-reverse.c
+set precsave [standard_output_file break.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
     return -1
@@ -45,14 +46,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save break.precsave" \
-    "Saved core file break.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore break.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload precord save file"
 
Index: gdb.reverse/consecutive-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/consecutive-precsave.exp,v
retrieving revision 1.9
diff -u -r1.9 consecutive-precsave.exp
--- gdb.reverse/consecutive-precsave.exp	26 Jun 2012 17:54:59 -0000	1.9
+++ gdb.reverse/consecutive-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -22,6 +22,7 @@
 }
 
 standard_testfile consecutive-reverse.c
+set precsave [standard_output_file consecutive.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
     return -1
@@ -41,14 +42,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save consecutive.precsave" \
-    "Saved core file consecutive.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore consecutive.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload precord save file"
 
Index: gdb.reverse/finish-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/finish-precsave.exp,v
retrieving revision 1.7
diff -u -r1.7 finish-precsave.exp
--- gdb.reverse/finish-precsave.exp	26 Jun 2012 17:54:59 -0000	1.7
+++ gdb.reverse/finish-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -21,6 +21,7 @@
 }
 
 standard_testfile finish-reverse.c
+set precsave [standard_output_file finish.precsave]
 
 if { [prepare_for_testing $testfile.exp "$testfile" $srcfile] } {
     return -1
@@ -42,14 +43,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save finish.precsave" \
-    "Saved core file finish.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore finish.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload precord save file"
 
Index: gdb.reverse/i386-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/i386-precsave.exp,v
retrieving revision 1.11
diff -u -r1.11 i386-precsave.exp
--- gdb.reverse/i386-precsave.exp	26 Jun 2012 17:54:59 -0000	1.11
+++ gdb.reverse/i386-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -31,6 +31,7 @@
 }
 
 standard_testfile i386-reverse.c
+set precsave [standard_output_file i386.precsave]
 
 # some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]
@@ -59,14 +60,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save i386.precsave" \
-    "Saved core file i386.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore i386.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload precord save file"
 
Index: gdb.reverse/machinestate-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/machinestate-precsave.exp,v
retrieving revision 1.7
diff -u -r1.7 machinestate-precsave.exp
--- gdb.reverse/machinestate-precsave.exp	26 Jun 2012 17:54:59 -0000	1.7
+++ gdb.reverse/machinestate-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -41,6 +41,7 @@
 }
 
 standard_testfile machinestate.c ms1.c
+set precsave [standard_output_file machinestate.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile \
 	  [list $srcfile $srcfile2]] } {
@@ -67,14 +68,14 @@
 
 gdb_test "continue" "Breakpoint .* end main .*" "run to end of main"
 
-gdb_test "record save machinestate.precsave" \
-    "Saved core file machinestate.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore machinestate.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload prec save file"
 
Index: gdb.reverse/sigall-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/sigall-precsave.exp,v
retrieving revision 1.10
diff -u -r1.10 sigall-precsave.exp
--- gdb.reverse/sigall-precsave.exp	26 Jun 2012 17:54:59 -0000	1.10
+++ gdb.reverse/sigall-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -28,6 +28,7 @@
 gdb_reinitialize_dir $srcdir/$subdir
 
 standard_testfile sigall-reverse.c
+set precsave [standard_output_file sigall.precsave]
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
@@ -183,14 +184,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save sigall.precsave" \
-    "Saved core file sigall.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore sigall.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload precord save file"
 
Index: gdb.reverse/solib-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/solib-precsave.exp,v
retrieving revision 1.10
diff -u -r1.10 solib-precsave.exp
--- gdb.reverse/solib-precsave.exp	26 Jun 2012 17:54:59 -0000	1.10
+++ gdb.reverse/solib-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -22,6 +22,7 @@
 }
 
 standard_testfile solib-reverse.c
+set precsave [standard_output_file solib.precsave]
 set libfile  "shr2"
 set libsrc   ${libfile}.c
 set library  [standard_output_file ${libfile}.sl]
@@ -74,14 +75,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save solib.precsave" \
-    "Saved core file solib.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore solib.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload core file"
 
Index: gdb.reverse/step-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/step-precsave.exp,v
retrieving revision 1.7
diff -u -r1.7 step-precsave.exp
--- gdb.reverse/step-precsave.exp	26 Jun 2012 17:54:59 -0000	1.7
+++ gdb.reverse/step-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -26,6 +26,7 @@
 }
 
 standard_testfile step-reverse.c
+set precsave [standard_output_file step.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
     return -1
@@ -45,14 +46,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save step.precsave" \
-    "Saved core file step.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore step.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload core file"
 
Index: gdb.reverse/until-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/until-precsave.exp,v
retrieving revision 1.9
diff -u -r1.9 until-precsave.exp
--- gdb.reverse/until-precsave.exp	26 Jun 2012 17:54:59 -0000	1.9
+++ gdb.reverse/until-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -22,6 +22,7 @@
 }
 
 standard_testfile until-reverse.c ur1.c
+set precsave [standard_output_file until.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile \
 	  [list $srcfile $srcfile2]] } {
@@ -53,15 +54,15 @@
 gdb_test "continue" "Breakpoint .* set breakpoint 10a here .*" "run to end of main"
 
 # So can this, against gdbserver, for example.
-gdb_test "record save until.precsave" \
-    "Saved core file until.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 set timeout $oldtimeout
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore until.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload core file"
 
Index: gdb.reverse/watch-precsave.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/watch-precsave.exp,v
retrieving revision 1.10
diff -u -r1.10 watch-precsave.exp
--- gdb.reverse/watch-precsave.exp	26 Jun 2012 17:54:59 -0000	1.10
+++ gdb.reverse/watch-precsave.exp	11 Jul 2012 15:18:34 -0000
@@ -23,6 +23,7 @@
 }
 
 standard_testfile watch-reverse.c
+set precsave [standard_output_file watch.precsave]
 
 if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
     return -1
@@ -42,14 +43,14 @@
 
 gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main"
 
-gdb_test "record save watch.precsave" \
-    "Saved core file watch.precsave with execution log\."  \
+gdb_test "record save $precsave" \
+    "Saved core file $precsave with execution log\."  \
     "save process recfile"
 
 gdb_test "kill" "" "Kill process, prepare to debug log file" \
     "Kill the program being debugged\\? \\(y or n\\) " "y"
 
-gdb_test "record restore watch.precsave" \
+gdb_test "record restore $precsave" \
     "Program terminated with signal .*" \
     "reload core file"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]