This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove -DFAKEARGV from compilation flags in gdb.mi.
- From: Pedro Alves <alves dot ped at gmail dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 06 Jul 2012 11:51:16 +0100
- Subject: Re: [PATCH] Remove -DFAKEARGV from compilation flags in gdb.mi.
- References: <1341541028-21268-1-git-send-email-yao@codesourcery.com>
On 07/06/2012 03:17 AM, Yao Qi wrote:
> Hi,
> When writing a test in gdb.mi, I see some cases are compiled with
> "debug additional_flags=-DFAKEARGV", but I don't see macro FAKEARGV
> is used in any c files under gdb.mi. I think this can be safely
> removed from all tests in gdb.mi. Unless I miss something, it is
> obvious to me. I'll apply this patch in three days if no objections.
Yeah. You can see in 878d2171 (Feb 2000), the initial MI revision,
that -DFAKEARGV was already present in most MI tests, but not used anywhere.
Clearly copy/paste.
Go right ahead.
>
> gdb/testsuite:
>
> 2012-07-05 Yao Qi <yao@codesourcery.com>
>
> * gdb.mi/gdb2549.exp: Remove -DFAKEARGV from compilation flags.
> * gdb.mi/mi-async.exp, gdb.mi/mi-basics.exp: Likewise.
> * gdb.mi/mi-break.exp, gdb.mi/mi-cli.exp: Likewise.
> * gdb.mi/mi-console.exp, gdb.mi/mi-disassemble.exp: Likewise.
> * gdb.mi/mi-eval.exp, gdb.mi/mi-file.exp: Likewise.
> * gdb.mi/mi-read-memory.exp, gdb.mi/mi-regs.exp: Likewise.
> * gdb.mi/mi-return.exp, gdb.mi/mi-reverse.exp: Likewise.
> * gdb.mi/mi-simplerun.exp, gdb.mi/mi-stack.exp: Likewise.
> * gdb.mi/mi-stepi.exp, gdb.mi/mi-syn-frame.exp: Likewise.
> * gdb.mi/mi-until.exp, gdb.mi/mi-var-block.exp: Likewise.
> * gdb.mi/mi-var-child.exp, gdb.mi/mi-var-cmd.exp: Likewise.
> * gdb.mi/mi-var-display.exp: Likewise.
> * gdb.mi/mi-var-invalidate.exp: Likewise.
> * gdb.mi/mi-watch.exp, gdb.mi/mi2-basics.exp: Likewise.
> * gdb.mi/mi2-break.exp, gdb.mi/mi2-cli.exp: Likewise.
> * gdb.mi/mi2-console.exp: Likewise.
> * gdb.mi/mi2-disassemble.exp: Likewise.
> * gdb.mi/mi2-eval.exp, gdb.mi/mi2-file.exp: Likewise.
> * gdb.mi/mi2-read-memory.exp: Likewise.
> * gdb.mi/mi2-regs.exp, gdb.mi/mi2-return.exp: Likewise.
> * gdb.mi/mi2-simplerun.exp: Likewise.
> * gdb.mi/mi2-stack.exp, gdb.mi/mi2-stepi.exp: Likewise.
> * gdb.mi/mi2-syn-frame.exp: Likewise.
> * gdb.mi/mi2-until.exp, gdb.mi/mi2-var-block.exp: Likewise.
> * gdb.mi/mi2-var-child.exp, gdb.mi/mi2-var-cmd.exp: Likewise.
> * gdb.mi/mi2-var-display.exp, gdb.mi/mi2-watch.exp: Likewise.
> ---
> gdb/testsuite/gdb.mi/gdb2549.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-async.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-basics.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-break.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-cli.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-console.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-disassemble.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-eval.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-file.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-read-memory.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-regs.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-return.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-reverse.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-simplerun.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-stack.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-stepi.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-syn-frame.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-until.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-var-block.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-var-child.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-var-cmd.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-var-display.exp | 2 +-
> gdb/testsuite/gdb.mi/mi-var-invalidate.exp | 6 +++---
> gdb/testsuite/gdb.mi/mi-watch.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-basics.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-break.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-cli.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-console.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-disassemble.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-eval.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-file.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-read-memory.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-regs.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-return.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-simplerun.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-stack.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-stepi.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-syn-frame.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-until.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-var-block.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-var-child.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-var-cmd.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-var-display.exp | 2 +-
> gdb/testsuite/gdb.mi/mi2-watch.exp | 2 +-
> 44 files changed, 46 insertions(+), 46 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.mi/gdb2549.exp b/gdb/testsuite/gdb.mi/gdb2549.exp
> index 79068b1..bf536de 100644
> --- a/gdb/testsuite/gdb.mi/gdb2549.exp
> +++ b/gdb/testsuite/gdb.mi/gdb2549.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-regs.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-async.exp b/gdb/testsuite/gdb.mi/mi-async.exp
> index 3beee7f..bab7673 100644
> --- a/gdb/testsuite/gdb.mi/mi-async.exp
> +++ b/gdb/testsuite/gdb.mi/mi-async.exp
> @@ -39,7 +39,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-async
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-async.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-basics.exp b/gdb/testsuite/gdb.mi/mi-basics.exp
> index 4c96d47..9ff27b4 100644
> --- a/gdb/testsuite/gdb.mi/mi-basics.exp
> +++ b/gdb/testsuite/gdb.mi/mi-basics.exp
> @@ -39,7 +39,7 @@ set binfile ${objdir}/${subdir}/mi-basics
> set escapedobjdir [string_to_regexp ${objdir}]
> set envirodir [string_to_regexp ${objdir}/${subdir}]
>
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-basics.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp
> index 65fe353..debfe86 100644
> --- a/gdb/testsuite/gdb.mi/mi-break.exp
> +++ b/gdb/testsuite/gdb.mi/mi-break.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-break
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-break.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-cli.exp b/gdb/testsuite/gdb.mi/mi-cli.exp
> index 0021308..598365b 100644
> --- a/gdb/testsuite/gdb.mi/mi-cli.exp
> +++ b/gdb/testsuite/gdb.mi/mi-cli.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-cli
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-cli.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-console.exp b/gdb/testsuite/gdb.mi/mi-console.exp
> index 10f8c71..83deff5 100644
> --- a/gdb/testsuite/gdb.mi/mi-console.exp
> +++ b/gdb/testsuite/gdb.mi/mi-console.exp
> @@ -39,7 +39,7 @@ if [mi_gdb_start separate-inferior-tty] {
> set testfile "mi-console"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-console.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-disassemble.exp b/gdb/testsuite/gdb.mi/mi-disassemble.exp
> index dcbc033..68038ae 100644
> --- a/gdb/testsuite/gdb.mi/mi-disassemble.exp
> +++ b/gdb/testsuite/gdb.mi/mi-disassemble.exp
> @@ -32,7 +32,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-disassemble
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-disassemble.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-eval.exp b/gdb/testsuite/gdb.mi/mi-eval.exp
> index 61a35cc..29d26a2 100644
> --- a/gdb/testsuite/gdb.mi/mi-eval.exp
> +++ b/gdb/testsuite/gdb.mi/mi-eval.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-eval
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-eval.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-file.exp b/gdb/testsuite/gdb.mi/mi-file.exp
> index 55239fe..3733107 100644
> --- a/gdb/testsuite/gdb.mi/mi-file.exp
> +++ b/gdb/testsuite/gdb.mi/mi-file.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-file
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-file.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-read-memory.exp b/gdb/testsuite/gdb.mi/mi-read-memory.exp
> index 4773c6d..af34de8 100644
> --- a/gdb/testsuite/gdb.mi/mi-read-memory.exp
> +++ b/gdb/testsuite/gdb.mi/mi-read-memory.exp
> @@ -36,7 +36,7 @@ if [mi_gdb_start] {
> set testfile "mi-read-memory"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-read-memory.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-regs.exp b/gdb/testsuite/gdb.mi/mi-regs.exp
> index e6b2b48..876de78 100644
> --- a/gdb/testsuite/gdb.mi/mi-regs.exp
> +++ b/gdb/testsuite/gdb.mi/mi-regs.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-regs
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-regs.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-return.exp b/gdb/testsuite/gdb.mi/mi-return.exp
> index b46f156..b7d931f 100644
> --- a/gdb/testsuite/gdb.mi/mi-return.exp
> +++ b/gdb/testsuite/gdb.mi/mi-return.exp
> @@ -34,7 +34,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-return
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-return.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-reverse.exp b/gdb/testsuite/gdb.mi/mi-reverse.exp
> index 08025bd..ce0983f 100644
> --- a/gdb/testsuite/gdb.mi/mi-reverse.exp
> +++ b/gdb/testsuite/gdb.mi/mi-reverse.exp
> @@ -42,7 +42,7 @@ if [mi_gdb_start] {
> set testfile mi-reverse
> set srcfile basics.c
> set binfile ${objdir}/${subdir}/mi2-reverse
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested ${testfile}.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-simplerun.exp b/gdb/testsuite/gdb.mi/mi-simplerun.exp
> index 2b74089..52aa0d7 100644
> --- a/gdb/testsuite/gdb.mi/mi-simplerun.exp
> +++ b/gdb/testsuite/gdb.mi/mi-simplerun.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-simplerun
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-simplerun.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-stack.exp b/gdb/testsuite/gdb.mi/mi-stack.exp
> index 6c0d625..f3fcd45 100644
> --- a/gdb/testsuite/gdb.mi/mi-stack.exp
> +++ b/gdb/testsuite/gdb.mi/mi-stack.exp
> @@ -34,7 +34,7 @@ if [mi_gdb_start] {
> set testfile "mi-stack"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-stack.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-stepi.exp b/gdb/testsuite/gdb.mi/mi-stepi.exp
> index 10e12be..5e119a3 100644
> --- a/gdb/testsuite/gdb.mi/mi-stepi.exp
> +++ b/gdb/testsuite/gdb.mi/mi-stepi.exp
> @@ -34,7 +34,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-stepi
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-stepi.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-syn-frame.exp b/gdb/testsuite/gdb.mi/mi-syn-frame.exp
> index 17a76be..34771ab 100644
> --- a/gdb/testsuite/gdb.mi/mi-syn-frame.exp
> +++ b/gdb/testsuite/gdb.mi/mi-syn-frame.exp
> @@ -27,7 +27,7 @@ set MIFLAGS "-i=mi"
> set testfile "mi-syn-frame"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-syn-frame.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-until.exp b/gdb/testsuite/gdb.mi/mi-until.exp
> index 6caf0a0..56d914f 100644
> --- a/gdb/testsuite/gdb.mi/mi-until.exp
> +++ b/gdb/testsuite/gdb.mi/mi-until.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "until"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-until.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-var-block.exp b/gdb/testsuite/gdb.mi/mi-var-block.exp
> index a362d64..601057a 100644
> --- a/gdb/testsuite/gdb.mi/mi-var-block.exp
> +++ b/gdb/testsuite/gdb.mi/mi-var-block.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-var-block
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-var-block.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-var-child.exp b/gdb/testsuite/gdb.mi/mi-var-child.exp
> index fb98c1d..cd3133d 100644
> --- a/gdb/testsuite/gdb.mi/mi-var-child.exp
> +++ b/gdb/testsuite/gdb.mi/mi-var-child.exp
> @@ -31,7 +31,7 @@ if [mi_gdb_start] {
> set testfile "mi-var-child"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-var-child.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-var-cmd.exp b/gdb/testsuite/gdb.mi/mi-var-cmd.exp
> index cadff9f..017e4f6 100644
> --- a/gdb/testsuite/gdb.mi/mi-var-cmd.exp
> +++ b/gdb/testsuite/gdb.mi/mi-var-cmd.exp
> @@ -31,7 +31,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-var-cmd
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-var-cmd.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-var-display.exp b/gdb/testsuite/gdb.mi/mi-var-display.exp
> index bc770d9..cf3ac80 100644
> --- a/gdb/testsuite/gdb.mi/mi-var-display.exp
> +++ b/gdb/testsuite/gdb.mi/mi-var-display.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-var-display
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-var-display.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-var-invalidate.exp b/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
> index f389e32..adeb442 100644
> --- a/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
> +++ b/gdb/testsuite/gdb.mi/mi-var-invalidate.exp
> @@ -31,13 +31,13 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-var-invalidate
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-var-invalidate.exp
> return -1
> }
> # Just change the output binary.
> set binfile_bis ${objdir}/${subdir}/mi-var-invalidate_bis
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_bis}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_bis}" executable {debug}] != "" } {
> untested mi-var-invalidate.exp
> return -1
> }
> @@ -45,7 +45,7 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_bis}" executable
> set testfile2 "basics"
> set srcfile2 ${testfile2}.c
> set binfile2 ${objdir}/${subdir}/${testfile2}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } {
> untested mi-var-invalidate.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
> index fde99dc..1fb2cc2 100644
> --- a/gdb/testsuite/gdb.mi/mi-watch.exp
> +++ b/gdb/testsuite/gdb.mi/mi-watch.exp
> @@ -36,7 +36,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi-watch
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi-watch.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-basics.exp b/gdb/testsuite/gdb.mi/mi2-basics.exp
> index 74fe3f6..67bba6e 100644
> --- a/gdb/testsuite/gdb.mi/mi2-basics.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-basics.exp
> @@ -39,7 +39,7 @@ set binfile ${objdir}/${subdir}/mi2-basics
> set escapedobjdir [string_to_regexp ${objdir}]
> set envirodir [string_to_regexp ${objdir}/${subdir}]
>
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-basics.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-break.exp b/gdb/testsuite/gdb.mi/mi2-break.exp
> index c6acc7c..14ad922 100644
> --- a/gdb/testsuite/gdb.mi/mi2-break.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-break.exp
> @@ -36,7 +36,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-break
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-break.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-cli.exp b/gdb/testsuite/gdb.mi/mi2-cli.exp
> index 6e15da6..3c7c6d5 100644
> --- a/gdb/testsuite/gdb.mi/mi2-cli.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-cli.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-cli
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-cli.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-console.exp b/gdb/testsuite/gdb.mi/mi2-console.exp
> index 36c098d..17f3423 100644
> --- a/gdb/testsuite/gdb.mi/mi2-console.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-console.exp
> @@ -39,7 +39,7 @@ if [mi_gdb_start] {
> set testfile "mi-console"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-console.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-disassemble.exp b/gdb/testsuite/gdb.mi/mi2-disassemble.exp
> index f2e6d67..66796d1 100644
> --- a/gdb/testsuite/gdb.mi/mi2-disassemble.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-disassemble.exp
> @@ -31,7 +31,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-disassemble
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-disassemble.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-eval.exp b/gdb/testsuite/gdb.mi/mi2-eval.exp
> index 564e617..74287e0 100644
> --- a/gdb/testsuite/gdb.mi/mi2-eval.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-eval.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-eval
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-eval.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-file.exp b/gdb/testsuite/gdb.mi/mi2-file.exp
> index c19b0e0..eb9d6b9 100644
> --- a/gdb/testsuite/gdb.mi/mi2-file.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-file.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-file
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-file.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-read-memory.exp b/gdb/testsuite/gdb.mi/mi2-read-memory.exp
> index 39e23c6..61a0efd 100644
> --- a/gdb/testsuite/gdb.mi/mi2-read-memory.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-read-memory.exp
> @@ -36,7 +36,7 @@ if [mi_gdb_start] {
> set testfile "mi-read-memory"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-read-memory.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-regs.exp b/gdb/testsuite/gdb.mi/mi2-regs.exp
> index d9a63d1..808c850 100644
> --- a/gdb/testsuite/gdb.mi/mi2-regs.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-regs.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-regs
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-regs.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-return.exp b/gdb/testsuite/gdb.mi/mi2-return.exp
> index e16ae20..d2b4836 100644
> --- a/gdb/testsuite/gdb.mi/mi2-return.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-return.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-return
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-return.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-simplerun.exp b/gdb/testsuite/gdb.mi/mi2-simplerun.exp
> index 5e1a084..c1cdc2f 100644
> --- a/gdb/testsuite/gdb.mi/mi2-simplerun.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-simplerun.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-simplerun
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-simplerun.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-stack.exp b/gdb/testsuite/gdb.mi/mi2-stack.exp
> index 031a90e..0d7c961 100644
> --- a/gdb/testsuite/gdb.mi/mi2-stack.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-stack.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "mi-stack"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-stack.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-stepi.exp b/gdb/testsuite/gdb.mi/mi2-stepi.exp
> index 56332db..ee09621 100644
> --- a/gdb/testsuite/gdb.mi/mi2-stepi.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-stepi.exp
> @@ -33,7 +33,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-stepi
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-stepi.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-syn-frame.exp b/gdb/testsuite/gdb.mi/mi2-syn-frame.exp
> index 0641cc3..ea9aa78 100644
> --- a/gdb/testsuite/gdb.mi/mi2-syn-frame.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-syn-frame.exp
> @@ -27,7 +27,7 @@ set MIFLAGS "-i=mi2"
> set testfile "mi-syn-frame"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-syn-frame.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-until.exp b/gdb/testsuite/gdb.mi/mi2-until.exp
> index 3d663c8..eff56aa 100644
> --- a/gdb/testsuite/gdb.mi/mi2-until.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-until.exp
> @@ -34,7 +34,7 @@ if [mi_gdb_start] {
> set testfile "until"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-until.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-var-block.exp b/gdb/testsuite/gdb.mi/mi2-var-block.exp
> index 3bd62a5..3eed535 100644
> --- a/gdb/testsuite/gdb.mi/mi2-var-block.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-var-block.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-var-block
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-var-block.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-var-child.exp b/gdb/testsuite/gdb.mi/mi2-var-child.exp
> index 8bc88e9..1497fd7 100644
> --- a/gdb/testsuite/gdb.mi/mi2-var-child.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-var-child.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-var-child
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-var-child.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-var-cmd.exp b/gdb/testsuite/gdb.mi/mi2-var-cmd.exp
> index dc26d65..96d328a 100644
> --- a/gdb/testsuite/gdb.mi/mi2-var-cmd.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-var-cmd.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-var-cmd
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-var-cmd.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-var-display.exp b/gdb/testsuite/gdb.mi/mi2-var-display.exp
> index d1429c8..d3b97a5 100644
> --- a/gdb/testsuite/gdb.mi/mi2-var-display.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-var-display.exp
> @@ -30,7 +30,7 @@ if [mi_gdb_start] {
> set testfile "var-cmd"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-var-display
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-var-display.exp
> return -1
> }
> diff --git a/gdb/testsuite/gdb.mi/mi2-watch.exp b/gdb/testsuite/gdb.mi/mi2-watch.exp
> index 8aa0d94..5c72eb4 100644
> --- a/gdb/testsuite/gdb.mi/mi2-watch.exp
> +++ b/gdb/testsuite/gdb.mi/mi2-watch.exp
> @@ -35,7 +35,7 @@ if [mi_gdb_start] {
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/mi2-watch
> -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> untested mi2-watch.exp
> return -1
> }
>
--
Pedro Alves