This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 6 Jun 2012 00:26:51 +0200
- Subject: Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST
- References: <20120220132724.GB4753@spoyarek.pnq.redhat.com> <20120221210235.GA26897@host2.jankratochvil.net> <20120504183858.67d416b7@spoyarek> <20120515200454.GA11338@host2.jankratochvil.net> <20120523192245.0f785e69@spoyarek> <20120523174610.GA23405@host2.jankratochvil.net> <20120524070634.4e346d9d@spoyarek> <20120524150105.GA8232@host2.jankratochvil.net> <20120531234422.3ea35cde@spoyarek>
On Thu, 31 May 2012 20:14:22 +0200, Siddhesh Poyarekar wrote:
> Here's a new draft of the patch I have been working on to expand bitpos
> and type.
There are some lines where the '-' line is <= 80 characters but the '+' line
is > 80 characters.
There is used %zd for size_t (not %zu?), %z is not compatible enough, cast it
to ULONGEST, use pulongest.
(I have not yet finished the review.)
Thanks,
Jan