This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/10] C language
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 04 Jun 2012 14:31:47 -0600
>
> Sergio> +#define yyparse _c_parse
>
> It is pedantically better to avoid names with a leading underscore.
> While it probably will never cause any problem in practice, I think it
> is also just as easy to pick pedantically-correct names at the outset.
>
> So, could you rename these to $LANG_parse_internal or something like that?
I hesitated to bring it up, but when I was looking into using the yacc
-p option to get rid of the #defines, the underscored names posed a
problem.
So if you go through the trouble of renaming things, it might make
sense to use a consistent prefix ($LANG_) and give the wrappers
different names.