RE: [PATCH 13/16] xml, btrace: define btrace xml document style

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
> Sent: Wednesday, May 30, 2012 10:44 PM

Thanks for your review!

[...]

> > +*attributes) {
> > +  const char *version = xml_find_attribute (attributes,
> > +"version")->value;
> 
> Empty line.

Fixed.

[...]

> > +const struct gdb_xml_attribute block_attributes[] = {
> 
> It can be static.  The same in other cases.

Fixed.

[...]

> > +#if defined(HAVE_LIBEXPAT)
> > +  cleanup = make_cleanup (xfree, btrace);
> 
> Use VEC_cleanup, not xfree.

Fixed.

> > +  errcode = gdb_xml_parse_quick (_("btrace"), "btrace.dtd",
> btrace_elements,
> > +                                 buffer, &btrace);  if (errcode)
> > +    {
> > +      do_cleanups (cleanup);
> > +      errno = errcode;
> > +      return NULL;
> > +    }
> > +
> > +  /* Keep parse results.  */
> > +  discard_cleanups (cleanup);
> > +#else  /* defined(HAVE_LIBEXPAT) */
> > +  errno = ENOSYS;
> 
> Again, use some error, not errno.

I guess I need to rework the entire error handling.

[...]

Regards,
Markus.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052