This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Wednesday, May 30, 2012 10:43 PM > To: Metzger, Markus T Thanks for your review! > > +static int > > +linux_nat_push_btrace_record (struct linux_btrace_block *raw, void > > +*arg) { > > + VEC (btrace_block_s) **btrace = arg; > > + struct btrace_block *block; > > + > > + if (!raw) > > + return EINVAL; > > + > > + if (!btrace) > > + return EINVAL; > > I did not check now but probably excessive. Removed. > > + > > + block = VEC_safe_push (btrace_block_s, *btrace, NULL); if (!block) > > + return ENOMEM; > > Incorrect indentation. Fixed. > > + > > + block->begin = raw->begin; > > + block->end = raw->end; > > Do not use alignment/indentation. Fixed. > > + > > + return 0; > > +} > > + > > +static VEC (btrace_block_s) * > > +linux_nat_read_btrace (struct btrace_target_info *tinfo) { > > + VEC (btrace_block_s) *btrace = NULL; > > + int errcode; > > + > > + if (!tinfo) > > + { > > + errno = EINVAL; > > + return NULL; > > + } > > + if (!tinfo->ptr_bits) > > + { > > + struct gdbarch *gdbarch = get_current_arch (); > > Empty line. Fixed. Replaced with target_gdbarch as by your earlier recommendation. > > + if (gdbarch) > > + tinfo->ptr_bits = gdbarch_ptr_bit (gdbarch); > > + } > > + > > + errcode = linux_read_btrace (tinfo, linux_nat_push_btrace_record, > > + &btrace); if (errcode) > > + warning (_("error while reading branch trace data: %s. " > > Captitalize "Error". Use two spaces at the end. Fixed. Regards, Markus.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
-------------------------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |