This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] microMIPS support


> Date: Thu, 17 May 2012 16:06:37 +0100
> From: "Maciej W. Rozycki" <macro@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
> 
> > > if I place a @menu reference to that node in any of the upper sections.  
> > 
> > That's most probably because you added only some of the menus, not all
> > of them.  The minor variation of your patch below doesn't have this
> > problem, it produces an Info manual without any warnings or errors.
> 
>  I added only some of the menus by your explicit request.  You rejected my 
> proposal that I made in response which added all of them and that was only 
> trivially different to the version you have proposed now.

In that case, I apologize for my initial misunderstanding.

> > > I'll be pushing it in this form as soon as the MIPS16 manual
> > > function call change has been committed.
> > 
> > I believe committing a patch over objections of the responsible
> > maintainer is against the rules described in MAINTAINERS (as I
> > understand them).  So please don't do that.
> 
>  Certainly, next time I'll just drop any changes to the manual I disagree 
> with.

I'd prefer that next time we could arrive at an agreement sooner.

> > Please use the slightly modified patch below instead.
> 
>  Thanks for your proposal, even though my original concern about pages 
> containing single-entry menus still stands.  This doesn't really matter 
> however for two reasons, first and foremost because you have the power to 
> override my objection to any changes to the manual, and second because it 
> contains changes irrelevant to my change and as such I cannot integrate 
> them.  Please split changes to the existing pieces of the manual off and 
> commit them separately.  I'll extract the rest and fold into my change.

Which changes are irrelevant?  I tried deliberately to put aside any
such unrelated changes, but maybe I missed some.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]