This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, May 10, 2012 at 7:56 PM, Pedro Alves <palves@redhat.com> wrote: > On 05/10/2012 05:18 AM, Hui Zhu wrote: > >> On 04/11/12 13:44, Hui Zhu wrote: >>> On 04/05/12 19:50, Pedro Alves wrote: >>>> On 04/05/2012 09:14 AM, Hui Zhu wrote: >>>> >>>>> I post a new version patch according to your comments. >>>>> And I have test it with gdb-7.4 and got fail. >>>> >>>> >>>> Thanks. ?Only a few nits remain, and this is technically ready to >>>> check in. ?See below. >>>> >>>> However, what's the status of your copyright assignment? ?Last I >>>> heard (and from what I see in FSF's copyright assignment records), we >>>> still can't accept changes from you on behalf of Mentor. ?:-( >>> >>> What I got is it is OK now. ?I will send you a mail and cc the people that about the law. >> >> Hi Pedro, >> >> The copyright issue is OK now. > > > Yep, took a while, but it's sorted now. ?Thanks for your patience. > >> Do you think I can check in this patch? > > > I took another look at the patch, and I now notice you didn't address > some of my early comments in <http://sourceware.org/ml/gdb-patches/2012-03/msg00987.html>: > >> Please always look at the resulting messages in gdb.sum: > .. >> There are duplicate messages here. ?See >> <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique>. >> >> I'd lowercase the "First", etc., in the test messages. ?It's much more common. > > This is what I get now: > >>cat testsuite/gdb.sum| grep PASS | sort | uniq -c | sort -nr > ? ? ?2 PASS: gdb.trace/disconnected-tracing.exp: reconnect after unload > ? ? ?2 PASS: gdb.trace/disconnected-tracing.exp: disconnect > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: tstart > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: trace main > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: Third info tracepoints > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: set disconnected-tracing on > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: set confirm off > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: Second info tracepoints > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: Fourth info tracepoints > ? ? ?1 PASS: gdb.trace/disconnected-tracing.exp: First info tracepoints > > Yao also made a valid comment here: > > <http://sourceware.org/ml/gdb-patches/2012-04/msg00124.html> > > that doesn't appear to have been addressed. > > -- > Pedro Alves Hi Pedro, I post a new version that lowercase the pass info and update Makefile.in according to Yao's comments. Please help me review it. Thanks, Hui 2012-05-10 Hui Zhu <hui_zhu@mentor.com> * gdb.trace/Makefile.in (PROGS): Add disconnected-tracing. * gdb.trace/disconnected-tracing.c: New file. * gdb.trace/disconnected-tracing.exp: New file.
Attachment:
disconnected-tracing.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |