This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GDB: Add microblaze-*-rtems*


On 05/08/2012 08:54 AM, Mark Kettenis wrote:
Date: Tue, 8 May 2012 08:30:58 -0500
From: Joel Sherrill<joel.sherrill@oarcorp.com>

OK to apply?

2012-05-07 Joel Sherrill<joel.sherrill@oarcorp.com>

* configure.tgt (microblaze*-*-rtems*): New target.
Eh, this diff is pretty much pointless isn't it?  It seems that from
GDB's viewpoint, RTEMS is effectively "bare metal".  I could live with
changing the comment if you think "running standalone" isn't accurate
enough, but I don't think we should add redundant patterns like this.
RTEMS is over 20 years old. In the past, I have seen bare metal
targets get changed without someone realizing they were
impacting RTEMS. This is as much advertising the target is
something to think about when you are hacking as anything
else.

I am ok with just merging it as a comment though if that's
sufficient to ensure that someone hacking here will consider
that they are having broader impact than is obvious.

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.253
diff -u -r1.253 configure.tgt
--- gdb/configure.tgt	24 Apr 2012 03:33:16 -0000	1.253
+++ gdb/configure.tgt	7 May 2012 20:15:54 -0000
@@ -331,8 +331,8 @@
  			monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
  	gdb_sim=../sim/microblaze/libsim.a
  	;;
-microblaze*-*-*)
-	# Target: Xilinx MicroBlaze running standalone
+microblaze*-*-* | microblaze*-*-rtems*)
+	# Target: Xilinx MicroBlaze running standalone (or RTEMS)
  	gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
  	gdb_sim=../sim/microblaze/libsim.a
  	;;


--
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]