Re: [PATCH] Autoload-breakpoints without report-async

[Hui Zhu <hui_zhu at mentor dot com>]

On 05/04/12 14:59, Eli Zaretskii wrote:
> > Date: Fri, 4 May 2012 09:00:30 +0800
> > From: Hui Zhu<hui_zhu@mentor.com>
> > CC:<gdb-patches@sourceware.org>,<Yao_Qi@mentor.com>,<stan_shebs@mentor.com>
> >
> > Oops, I post the wrong version.  The attachment is the right version.  Please help me review it.
> > +@item set breakpoint autoload query
> > +If this option is @samp{query} (the default), @value{GDBN} will query to user
>                                                                     ^^^^^^^^^^^^^
> "query the user"
>
> > +how to handle the autoload-breakpoints when @value{GDBN} connect to the stub.
>                                                              ^^^^^^^
> "connects"
>
> > +@item set breakpoint autoload stub
> > +If this option is @samp{stub}, the autoload-breakpoints of GDB will be removed
>                                                                ^^^
> "@value{GDBN}"
>
> > +@item @samp{QBDP}@var{autoload-breakpoints base format}
> > +@value{GDBN} use this packet to control the autoload-breakpoints in the remote.
>                  ^^^
> "uses"
>
> > +@table @samp
> > +
> > +@item @var{id}@samp{:}@var{command}@samp{:}@var{addr_string}@samp{:}@var{type}@samp{:}@var{ignore_num}
>
> The whole table uses @samp as the default typeface, so you don't need
> @samp in the @item line.  Every piece of text there that doesn't have
> an explicit markup will be typeset as @samp automatically.
>
> > +@item @var{id}
> > +This is the id in hex string format of this command want to control.
> > +this command wants to control.
>
>   This is the id in hex string format of the breakpoint to which to
>   apply this command.
>
> > +                       @value{GDBN} will create this breakpoint as
> > +it have been created in the target.  So when the target creates the
> > +breakpoint, it needs to insert this breakpoint by itself.
>
>    @value{GDBN} will assume the breakpoint already exists and is
>    inserted in the remote, so the target needs to insert the breakpoint
>    when it creates it.
>
> > +When @value{GDBN} or the target get this packet, it will delete
> > +the autoload-breakpoint @var{id}.                ^^^^^^^^^^^^^^
>
> "they will delete"
>
> OK with these changes.
>
> Thanks.

Hi Eli,

Thanks for your review.  This is the new patch that is updated by your commnets.

Best,
Hui

2012-05-04  Hui Zhu  <hui_zhu@mentor.com>

	* gdb.texinfo (Setting Breakpoints): Add set breakpoint autoload.
	(Remote Serial Protocol): Add Autoload-breakpoints Format.

Attachment: autoload-breakpoints-doc.txt
Description: Text document