This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] MIPS16 FP manual call/return fixes


On Thu, 26 Apr 2012, Maciej W. Rozycki wrote:

> > Maciej> 	* value.h (using_struct_return): Likewise.
> > 
> > I noticed that sparc-tdep.c calls this, but your patch doesn't update
> > it.
> 
>  Good catch, thanks!  I'll see how I can deal with that.  It seems to me I 
> may be able to regression-test it too, let me see...

 So this was a red herring after all, the argument in question is NULL 
here, so the type does not matter as in some other places touched by the 
patch.  Chances are I already considered it and disregarded before (by 
proofreading only, though) -- this patch is long-lived enough this may 
well have been many years ago, so I don't remember anymore.

 There are no regression for the sparc-solaris2.8 native target, GCC, 
using 32-bit and 64-bit (-m64) multilibs -- with the patch as is.

 However while attempting to do this I hit two problems for which I'll 
post patches separately: program name transformation breakage in 
gdb/configure and function prototype breakage in /proc services.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]