This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/3] Initial Fission support, rewrite DIE reading
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org, ccoutant at google dot com, saugustine at google dot com
- Date: Thu, 26 Apr 2012 15:15:18 -0600
- Subject: Re: [RFA 2/3] Initial Fission support, rewrite DIE reading
- References: <20120418185511.0AED52461AF@ruffy.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> This is the second patch in the Fission series and an updated
Doug> version of what I posted earlier:
Doug> http://sourceware.org/ml/gdb-patches/2012-04/msg00337.html
Doug> Ok to commit?
I found the patch pretty hard to read.
It looked like you moved some functions around, making it harder to
understand as a patch.
Anyway, nothing really stuck out for me. I think it is ok.
Tom