This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
- From: Will Deacon <will dot deacon at arm dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "palves at redhat dot com" <palves at redhat dot com>
- Date: Thu, 26 Apr 2012 19:36:36 +0100
- Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
- References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <201204261412.33446.vapier@gentoo.org>
Hi Mike,
On Thu, Apr 26, 2012 at 07:12:31PM +0100, Mike Frysinger wrote:
> On Thursday 26 April 2012 14:03:00 Will Deacon wrote:
> > +/* PTRACE_TEXT_ADDR and friends. */
> > +#include <asm/ptrace.h>
>
> check for asm/ptrace.h in configure.ac and then just depend on
> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is realistically
> the only C library being used with no-mmu Linux systems.
I'll see how Pedro gets on with the unconditional include first.
> > #if defined(__UCLIBC__) && defined(HAS_NOMMU)
> > +#if !(defined(PT_TEXT_ADDR) || \
> > + defined(PT_DATA_ADDR) || \
> > + defined(PT_TEXT_END_ADDR))
>
> i think the GNU way is to have the || at the start of line rather than end,
> and a space before the "(" (although i can see that rule isn't completely
> honored in this file).
Thanks, will fix.
Will