Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 26 April 2012 14:03:00 Will Deacon wrote:
> +/* PTRACE_TEXT_ADDR and friends.  */
> +#include <asm/ptrace.h>

check for asm/ptrace.h in configure.ac and then just depend on 
HAVE_ASM_PTRACE_H ?  although this is fine too since uClibc is realistically 
the only C library being used with no-mmu Linux systems.

>  #if defined(__UCLIBC__) && defined(HAS_NOMMU)
> +#if !(defined(PT_TEXT_ADDR) || \
> +      defined(PT_DATA_ADDR) || \
> +      defined(PT_TEXT_END_ADDR))

i think the GNU way is to have the || at the start of line rather than end, 
and a space before the "(" (although i can see that rule isn't completely 
honored in this file).
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.