Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h

[Will Deacon <will dot deacon at arm dot com>]

On Thu, Apr 26, 2012 at 05:02:18PM +0100, Pedro Alves wrote:
> On 04/26/2012 04:54 PM, Will Deacon wrote:
> > 
> > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> > index 35d7e69..93d1f36 100644
> > --- a/gdb/gdbserver/linux-low.c
> > +++ b/gdb/gdbserver/linux-low.c
> > @@ -4772,6 +4772,8 @@ linux_stopped_data_address (void)
> >  #define PT_TEXT_ADDR     (0x10000*4)
> >  #define PT_DATA_ADDR     (0x10004*4)
> >  #define PT_TEXT_END_ADDR (0x10008*4)
> > +#else
> > +#include <asm/ptrace.h>
> >  #endif
> 
> 
> I'd much rather we include asm/ptrace.h unconditionally at the top, and wrap the
> existing #defines in (a single) #ifndef PT_TEXT_ADDR.  That'll allow easily trimming
> that section in a few years time, if/when we bump the minimum kernel version
> required past a version that is known to define those for those archs.  If that breaks
> one of those archs, we'll hear about it soon enough, don't sweat about it.  :-)

Right-o. I did actually try that initially but it gets fairly ugly if you
want to deal with the case where only a subset of the #defines exist in the
header. If breaking these archs isn't a big concern up-front, then I'm happy
just to test PT_TEXT_ADDR for each of them and be done with it. Plus, that
should take care of the sane configurations.

Will