This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

ARI troubles


  Hi all,
it's been a long time since I really looked at the ARI web page...
I wanted to remove the inline ARI rule as
discussed earlier on the list.


It degraded quite a lot recently:

http://sourceware.org/gdb/current/ari/

But most of the critical renentrant bugs are just
problems releated to introduction
of
common/common-utils.[ch]

My problem here is that the same gdb_ari.sh script
is used both for trunk as well as fixes branch...

How should I cope with such changes?




Pierre Muller
GDB pascal language maintainer


PS: Should I commit the change below
that effecitvely removed inline ARI rule?


Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.110
diff -u -p -r1.110 gdb_ari.sh
--- gdb_ari.sh  30 May 2011 19:55:37 -0000      1.110
+++ gdb_ari.sh  24 Apr 2012 22:39:35 -0000
@@ -676,15 +676,16 @@ FNR == 1 {
     }
 }

-BEGIN { doc["inline"] = "\
-Do not use the inline attribute; \
-since the compiler generally ignores this, better algorithm selection \
-is needed to improved performance"
-    category["inline"] = ari_code
-}
-/(^|[^_[:alnum:]])inline([^_[:alnum:]]|$)/ {
-    fail("inline")
-}
+# Commented out, but left inside sources, just in case.
+# BEGIN { doc["inline"] = "\
+# Do not use the inline attribute; \
+# since the compiler generally ignores this, better algorithm selection \
+# is needed to improved performance"
+#    category["inline"] = ari_code
+# }
+# /(^|[^_[:alnum:]])inline([^_[:alnum:]]|$)/ {
+#     fail("inline")
+# }

 # This test is obsolete as this type
 # has been deprecated and finally suppressed from GDB sources
cvs diff: Diffing CVSROOT


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]