This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Make breakpoint condition detection trace conditional on remote_debug.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 8 Mar 2012 10:42:22 -0800
- Subject: [RFA] Make breakpoint condition detection trace conditional on remote_debug.
Hello,
I am investigating a problem where a breakpoint with a condition
no longer stops the program when running the program through gdbserver.
One of the things I noticed is this message that keeps popping up in
the gdbserver output:
% gdbserver :4444 a
Process a created; pid = 10100
Listening on port 4444
Remote debugging from host 127.0.0.1
Found breakpoint condition.
Found breakpoint condition.
Found breakpoint condition.
This looks like a debugging trace that should only be enable if
requested.
What do you guys think of this patch. I'm a little under pressure,
so I didn't test the patch, but I will if it looks correct. I wasn't
sure whether I should have used debug_threads or remote_debug...
gdb/gdbserver/ChangeLog:
* server.c (process_point_options): If a conditional expression
is found, only print a message if remote_debug is nonzero.
Thanks,
--
Joel
---
gdb/gdbserver/server.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index 586581c..3c97dbd 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -2908,7 +2908,8 @@ process_point_options (CORE_ADDR point_addr, char **packet)
{
case 'X':
/* Conditional expression. */
- fprintf (stderr, "Found breakpoint condition.\n");
+ if (remote_debug)
+ fprintf (stderr, "Found breakpoint condition.\n");
add_breakpoint_condition (point_addr, &dataptr);
break;
default:
--
1.7.1