This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Testsuite regression for annota1.exp and annota3.exp [Re: [PATCH] [SH] ... can do this signal stuff!]


On Tue, 28 Feb 2012 20:08:30 +0100, Thomas Schwinge wrote:
> 142db50201b1b1c69ebdc2dcdb1181cde1db3b08 I got the idea of using [concat
> ...] for building gdb_expect_list's third list argument -- it needs to
> expand $main_line, etc.  Any better suggestions (I obviously don't have a
> lot of TCL and/or GDB testcase writing experience), or is this
> acceptable?

I find it OK.

Please edit in your patch:
> +    "Breakpoint.*at.* file .*$srcfile, line $main_line\." \
->
  +    "Breakpoint.*at.* file .*$srcfile, line $main_line\\." \

(as \. is just TCL character . and regex then just gets ., not \.)


I would just write stupid:

gdb_expect_list "break at main" "$gdb_prompt$" [list	\
    "\r\n\032\032post-prompt\r\n"			\
    "Breakpoint 4 at 0x\[0-9a-z\]+: file .*annota3.c, line $main_line.\r\n"]

But fine with me with your / Tom's solution avoiding those backslashes.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]