This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: fix some performance bugs with .gdb_index

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Mon, 20 Feb 2012 21:42:28 +0100, Tom Tromey wrote:
>> +      visited_found = htab_create_alloc (10,
>> +					 htab_hash_pointer, htab_eq_pointer,
>> +					 NULL, xcalloc, xfree);
Jan> [...]
>> +      visited_not_found = htab_create_alloc (10,
>> +					     htab_hash_pointer, htab_eq_pointer,
>> +					     NULL, xcalloc, xfree);
Jan> [...]
>> +  htab_t visited = htab_create_alloc (10, htab_hash_pointer, htab_eq_pointer,
>> +				      NULL, xcalloc, xfree);

Jan> Just wouldn't be obstack + hashtab_obstack_allocate more
Jan> appropriate here?

I don't think it would make a very big difference.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]