This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com
Date: Fri, 17 Feb 2012 21:00:30 +0000
Subject: Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup
References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> <87pqdd9pjs.fsf@fleche.redhat.com>

On 02/17/2012 08:24 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> - build different executable files for the non-threaded and threaded
> Pedro>   cases.  This was my motivation.  I wanted to test the non-threaded
> Pedro>   case manually, but the threaded variant always clobbered the
> Pedro>   non-threaded executable.
> 
> I think this ought to be a general rule.  We need exceptions to it for
> some executable-changed cases, but I think in general different tests
> should build different executables, because this makes it easier to do
> additional checking by hand.

Yeah, agreed.  Perhaps we should write it down somewhere.
I guess the wiki's test cookbook could be a good place.

-- 
Pedro Alves

References:
- [PATCH 0/2] gdb.threads/attach-into-signal.exp: prepare for gdbserver
  - From: Pedro Alves
- [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup
  - From: Pedro Alves
- Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]