Re: [patch] Assert when 'break' with no arguments

[Aleksandar Ristovski <aristovski at qnx dot com>]

On 12-02-14 03:12 PM, Alfred M. Szmidt wrote:
>     2012-02-14  Aleksandar Ristovski<aristovski@qnx.com>
>
> 	* frame.c (find_frame_sal): Initialise sal->pspace field from frame
> 	data.
>
> I'm guessing that American spelling is prefered, since that is what is
> used in GDB.

Changed.

> 	* stack.c (set_last_displayed_sal): Perform sanity check of the data
> 	passed in, in particular, validate that PSPACE is not NULL if requesting
> 	valid last_displayed_* data.
>
> Please don't use regexps in the ChangeLog.  Also, descriptions on why
> the change is done is better placed in the source file.  So here, you
> could just write:
>
>    Validate that PSPACE is not NULL.

Ok.

> Or something,
>
>     Testsuite:
>     2012-02-14  Aleksandar Ristovski<aristovski@qnx.com>
>
> 	* gdb.base/break-inline.exp: New test.
> 	* gdb.base/break-inline.c: New test.
>
> This should say `New file.' since that is what you have added.

Ok.

> Space after opening paren (though not for _()).

Ok.

>        Copyright (C) 2012 Free Software
>        Foundation, Inc.
>
> This isn't formated correctly.

Ok.


Other changes performed as well.


2012-02-14  Aleksandar Ristovski  <aristovski@qnx.com>

    * frame.c (find_frame_sal): Initialize sal->pspace field from frame
    data.
    * stack.c (set_last_displayed_sal): Validate that PSPACE is not NULL.



2012-02-14  Aleksandar Ristovski  <aristovski@qnx.com>

    * gdb.base/break-inline.exp: New file.
    * gdb.base/break-inline.c: New file.



Patch + tests attached.


Thanks,

Aleksandar



Index: gdb/frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.304
diff -u -p -r1.304 frame.c
--- gdb/frame.c	4 Jan 2012 08:17:02 -0000	1.304
+++ gdb/frame.c	14 Feb 2012 20:43:07 -0000
@@ -2096,6 +2096,8 @@ find_frame_sal (struct frame_info *frame
 	   we can't do much better.  */
 	sal->pc = get_frame_pc (frame);
 
+      sal->pspace = get_frame_program_space (frame);
+
       return;
     }
 
Index: gdb/stack.c
===================================================================
RCS file: /cvs/src/src/gdb/stack.c,v
retrieving revision 1.247
diff -u -p -r1.247 stack.c
--- gdb/stack.c	7 Feb 2012 04:48:22 -0000	1.247
+++ gdb/stack.c	14 Feb 2012 20:43:08 -0000
@@ -909,6 +909,11 @@ set_last_displayed_sal (int valid, struc
   last_displayed_addr = addr;
   last_displayed_symtab = symtab;
   last_displayed_line = line;
+  if (valid && pspace == NULL)
+    {
+      warning (_("Trying to set NULL pspace."));
+      clear_last_displayed_sal ();
+    }
 }
 
 /* Forget the last sal we displayed.  */

Attachment: break-inline.exp
Description: Text document

/* This testcase is part of GDB, the GNU debugger.

   Copyright (C) 2012 Free Software Foundation, Inc.

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 3 of the License, or
   (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

static int g;

static inline void
foo (void)
{
  g = 42;
}

int
main (int argc, char *argv[])
{
  foo ();
  return g;
}