This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 7/8] Agent capability for static tracepoint
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 10 Feb 2012 22:29:23 +0800
- Subject: Re: [patch 7/8] Agent capability for static tracepoint
- References: <4F1D55D7.7030506@codesourcery.com> <4F1D6994.1080902@codesourcery.com> <4F3428D4.5060202@redhat.com>
On 02/10/2012 04:13 AM, Pedro Alves wrote:
> On 01/23/2012 02:07 PM, Yao Qi wrote:
>> > Current libinproctrace.so agent is able to do operations on static
>> > tracepoint, which can be treated as one capability. This patch is to
>> > teach gdbserver to check agent's capability when performing operations
>> > related to static tracepoint.
>> >
> Hmm, not sure. Why aren't these being hooked at the same places
> where we already check/call maybe_write_ipa_ust_not_loaded and
> in_process_agent_loaded_ust?
>
maybe_write_ipa_ust_not_loaded and in_process_agent_loaded_ust returns
agent is loaded or not. Considering GDB may/will support multiple
different agents, which have different capability, so "agent is loaded"
doesn't mean "agent has a certain capability". Is it reasonable?
I'd like replace global variable `ust_loaded' with capability mechanism
in agent.
--
Yao (éå)