This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Make names in gdbtypes.h,symtab.h const char *.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 06 Feb 2012 11:45:03 -0700
- Subject: Re: [RFA 1/2] Make names in gdbtypes.h,symtab.h const char *.
- References: <20120202224938.233881E25BF@ruffy2.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> The concept is trivial: Change the name strings in gdbtypes.h,symtab.h
Doug> from char * to const char *. Except for a couple of special cases
Doug> (documented in gdbtypes.h), all names do not come from malloc space,
Doug> and are generally freed with the objfile.
Doug> Recording them as const char * is cleaner.
I agree that it is cleaner.
I skimmed this patch and didn't see anything weird.
Tom