[RFA] Linespec tweak (was: Re: [RFA take 3] Allow setting breakpoints on inline functions (PR 10738))

[Gary Benson <gbenson at redhat dot com>]

Jan Kratochvil wrote:
> On Fri, 27 Jan 2012 16:10:34 +0100, Gary Benson wrote:
> > @@ -348,14 +375,16 @@ iterate_name_matcher (const char *name, void *d)
> >  /* A helper that walks over all matching symtabs in all objfiles and
> >     calls CALLBACK for each symbol matching NAME.  If SEARCH_PSPACE is
> >     not NULL, then the search is restricted to just that program
> > -   space.  */
> > +   space.  If INCLUDE_INLINE is nonzero then symbols representing
> > +   inlined instances of functions will be included in the result.  */
> >  
> >  static void
> >  iterate_over_all_matching_symtabs (const char *name,
> >  				   const domain_enum domain,
> >  				   int (*callback) (struct symbol *, void *),
> 
> Could you provide a pre-requisite patch turning this CALLBACK
> argument type into symbol_found_callback_ftype typedef where
> its result would be described (which is described in
> la_iterate_over_symbols but that is a bit far away).  And possibly
> commenting all the 0 and 1 return values in the implementations.
> I would do it otherwise.

Attached.  I also commented the return values of another callback used
internally by iterate_over_all_matching_symtabs, at the very top of
the patch.

Ok to commit?

Cheers,
Gary

-- 
http://gbenson.net/

Attachment: sdfkjkljs.patch
Description: Text document