This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PowerPC 32 with Secure PLT

From: Michael Eager <eager at eagerm dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Wed, 18 Jan 2012 09:13:39 -0800
Subject: Re: [PATCH] PowerPC 32 with Secure PLT
References: <4F163E35.1080505@eagerm.com> <20120118120831.GB31383@adacore.com> <4F16E632.6010102@eagerm.com> <4F16F527.2000800@eagerm.com> <20120118164917.GD31383@adacore.com>

On 01/18/2012 08:49 AM, Joel Brobecker wrote:

This is an area where I am not sure, but I think it would be better
to use read_memory_typed_address. I think the address type that you
want is: builtin_type (gdbarch)->builtin_func_ptr.


I think I'd rather leave the size explicit, rather than making
it indirect (and unclear).  This routine is only for PowerPC 32 and
the size of the value is always four bytes.


That would be fine with me. You should be able to get rid of the cast,
though. No?

Yep, and the cast above on the call to get_frame_register_unsigned().

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

References:
- [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Joel Brobecker
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Michael Eager
- Re: [PATCH] PowerPC 32 with Secure PLT
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]