Re: [rfc v2][0/6] Remote /proc file access

[Pedro Alves <palves at redhat dot com>]

On 01/16/2012 05:28 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>> I've been through the series, and it looks good to me.
>> Thanks a lot!  If this doesn't work out in the end, I'll certainly help
>> sort it out.
> 
> Thanks for the review!
> 
>> I've given a couple comments in reply to the patches directly.  I'm leaving
>> some general-ish comments here:
>>
>>  - We could consider making "info proc" work with the default run
>>    target if the current target can't handle it, so that
>>    "info proc PID" works even when not debugging a process yet,
>>    like today.
> 
> Maybe.  On the other hand, once we've switched to the gdbarch based
> implementation, it would automatically work when not yet debugging
> a process anyway, so I'm not sure this is really necessary ...

Hmm.  I though the target_file_xxx routines would all fail, hitting the default
when no target implement the methods that way.  IOW, I was thinking that we'd
need to pass the struct target_ops pointer down to the gdbarch callback so
the callback could work with the correct target.

-- 
Pedro Alves