This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).

On Fri, 13 Jan 2012 00:17:55 +0100, Doug Evans wrote:
> OOC, Jan, what discussion led rise to having braces here:

There was only Mark's agreement with me as I read now:
	Re: Code formatting [Re: [patch] s390*: watchpoints regression [repost]]
	http://sourceware.org/ml/gdb-patches/2011-12/msg00600.html

So still not sure what is the general consensus.


> and does that reasoning apply here:
> 
> +  if (debuglink == NULL)
> +    /* There's no separate debug info, hence there's no way we could
> +       load it => no warning.  */
> +    return NULL;

There exist already many cases in GDB not compliant with this rule.


Regards,
Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]