This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: add relative file name handling for linespecs
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 11 Jan 2012 08:53:30 +0400
- Subject: Re: RFC: add relative file name handling for linespecs
- References: <m3d3arlez3.fsf@fleche.redhat.com>
> 2012-01-10 Tom Tromey <tromey@redhat.com>
>
> * NEWS: Add item.
> * symtab.h (compare_filenames_for_search): Declare.
> * symtab.c (compare_filenames_for_search): New function.
> (iterate_over_some_symtabs): Use it.
> * symfile.h (struct quick_symbol_functions)
> <map_symtabs_matching_filename>: Change spec.
> * psymtab.c (partial_map_symtabs_matching_filename): Use
> compare_filenames_for_search. Update for new spec.
> * dwarf2read.c (dw2_map_symtabs_matching_filename): Use
> compare_filenames_for_search. Update for new spec.
FWIW, the patch looks good to me. I think that this is an awesome
enhancement.
One thing I noticed is that we might want to apply the same treatement
to the "clear" command... It uses the filename_cmp function directly,
instead of using the FILENAME_CMP macro.
--
Joel