This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[15/17] add comment


This one is trivial, probably doesn't need a full patch.
It is only separate because I originally had a FIXME here while I worked
on other things.

ada_decode_symbol operates on a general_symbol_info but has no provision
for minimal symbols not using obj_section.  Based on reading through the
code, I think this spot can never be reached for a minimal symbol.
(If that is in error it can be fixed though.)

Tom

>From 0a7339889fe98ec3224f0627f80d68f44eba5e38 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Wed, 7 Dec 2011 14:33:30 -0700
Subject: [PATCH 15/18] add comment for Ada

---
 gdb/ada-lang.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 81a0fe6..6c130f5 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -1258,6 +1258,8 @@ ada_decode_symbol (const struct general_symbol_info *gsymbol)
 
       if (gsymbol->sinfo.obj_section != NULL)
         {
+	  /* Note that there is no path to this code for minimal
+	     symbols.  */
 	  struct objfile *objf = gsymbol->sinfo.obj_section->objfile;
 
 	  *resultp = obsavestring (decoded, strlen (decoded),
-- 
1.7.6.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]