This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: set multiple-symbol ask/cancel not working


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> Since the "canonical form" doesn't actually have to be valid input to
Tom> linespec (it is only used for filtering the results -- well, it is now
Tom> that I fixed a couple of bad uses), I went ahead and changed
Tom> linespec.c:add_sal_to_sals to use FILE:FUNCTION:LINE for the canonical
Tom> form in this case.

Tom> This gives:

Tom> (gdb) b pck.adb:normal_Menu
Tom> [0] cancel
Tom> [1] all
Tom> [2] pck.adb:pck.normal_menu:4
Tom> [3] pck.adb:pck.normal_menu:8

I am not at all sure about doing this.  It means that the breakpoint
will stop working if the line number changes.

Maybe this is ok, since it is what the user asked for in
multiple-symbols=ask mode -- not the default, so he essentially asked
twice.

Another option would be to only apply this treatment to Ada.

I'll send the current patches, with this in place, regardless.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]