This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] mi/10586


On 11/14/2011 07:45 AM, Tom Tromey wrote:

ChangeLog should mention the PR.

That would be useful, no? I don't know why I sometimes forget. I've added that.


Keith>  +	type_name = TYPE_FIELD_NAME (type, index);
Keith>  +	if (*type_name == '\0')
Keith>  +	  name = xstrprintf ("anonymous%d", index);
Keith>  +	else
Keith>  +	  name = type_name;

What happens if there is a clash between a named field's name and the
generated name for an anonymous field?

Ha. My guess: bad things (TM).


Given that variables cannot start with numbers, I've changed the name string to "%d_anonymous".

Other comments?
Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]