This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit/procfs] /proc/.../map file descriptor leak
> > This tickled a memory:
> >
> > http://sourceware.org/ml/gdb-patches/2008-10/msg00683.html
> >
> > I didn't touch iterate_over_mappings though, so the old patch is
> > complementary.
>
> Argh. The part that changes the checks against zero might be a little
> theoretical, and thus have no real effect, but the missing cleanups
> are not. We should commit the patch. On solaris, I still cannot run
> the testsuite (causing an awful machine crash), but I can run the AdaCore
> testsuite. That's better than nothing.
I tested the patch, and found no regression, so I checked it in.
> > I think your patch is good. I agree it is cleaner the way you wrote it.
>
> Thanks for taking a look! I will commit momentarily.
This one is in as well....
--
Joel