This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] print-threads.exp: Extend timeout for slower tests.

On Tue, 08 Nov 2011 09:11:31 +0100, Doug Evans wrote:
> There are no existing uses of gdb_test_timeout outside of lib/gdb.exp,
> and regardless, I prefer my patch.  "timeout" is a standard global variable
> .exp writers know about.  Adding gdb_test_timeout is one more global,
...
>  Once I'm in a testsuite .exp file, I'd rather not have to involve it
> in my hacking.

Every GDB .exp has to heavily depend on lib/gdb.exp.
And for new GDB contributors TCL is exactly as new as lib/gdb.exp.

I see it was not misunderstanding but rather a real disagreement.
I do not mind, this is just bikeshedding, other patches need more reviews.


Thanks,
Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]